Drop OCCA backends #1007
Closed
Drop OCCA backends #1007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremylt
force-pushed
the
jeremy/drop-occa
branch
2 times, most recently
from
5ecc67b
to
3bef58a
Compare
|
Updated for changes in main. Since the OCCA backend does not function and we do not have anyone who is able to fix it, the question really is - why would we not remove this broken and unmaintained code? |
jeremylt
force-pushed
the
jeremy/drop-occa
branch
from
3bef58a
to
4d13e56
Compare
|
@jedbrown @tzanio, since we have the CEED6AM meeting this week, I think we have a chance to finally make a decision here. I think that if we can't find someone who can do the massive fixes + ongoing basic maintance that the OCCA backend requires, I think we should go ahead with this PR and remove the OCCA backend. We can always revive it from Git history if someone wants to revive the backend in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #816
Fixes #678
This backend compiles but does not run, and there are several known bugs in the implementation. Since this backend has not had a maintainer in 533 days, we don't have an avenue to fix it. The design of this backend is radically different that the rest of the backends, so our current maintainers would need extensive time to first learn OCCA and the design of the backend before starting to fix all of the bugs in this backend.
At this time, I am aware of no current users for this backend (makes sense, as this backend doesn't even pass the test suite anymore).
I think we should drop this backend. If we get support from an OCCA developer in the future who wants to assume responsibility for maintaining this backend, they can revert this commit if they wish to attempt repairing this version of the backend.